Android Code Review Checklist

Photo by Estée Janssens on Unsplash

I came across Michaela Greiler’s Code Review Checklist earlier this year and it’s now one of my favorite and most frequently-used programming resources. However, it’s a high-level checklist and doesn’t include anything specific to a platform or a language. I decided to write an Android-specific one. It’s meant to be used as a supplement to Michaela’s rather than as a replacement. All her high-level points apply to Android development as well, but I’m adding additional points to check when reviewing Android code. There are also a few non-Android-specific points — mostly things to watch out for in existing code (eg. outdated code comments) or things relevant to general front-end engineering (eg. user-facing error messages), since the checklist doesn’t include them.

Implementation

Does the code follow the project’s architectural patterns?

• Eg. if you’re using MVP, business logic should be in a presenter class rather than an Activity or Fragment.

Does the code follow the project’s coding style guide?

• This could be a company’s internal style guide, Kotlin Coding Conventions, Google’s Java Guide, etc.